Skip to content

OCPBUGS-60628: certrotation: ensure that all rotated secrets/configmaps have RefreshOnlyWhenExpired set #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

OCPBUGS-60628: certrotation: ensure that all rotated secrets/configmaps have RefreshOnlyWhenExpired set #1900

merged 1 commit into from
Aug 20, 2025

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Aug 19, 2025 •
edited
Loading

This prevents sidecar controllers from reverting metadata updates during cluster upgrade.

Merging this and its backport to 4.19 will unblock #1870, which shows that currently controllers are rewriting each other metadata changes on upgrade

@vrutkovs
certrotation: ensure that all rotated secrets/configmaps have Refresh…
c6a4211 
…OnlyWhenExpired set

This prevents sidecar controllers from reverting metadata updates during cluster upgrade.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 19, 2025

@vrutkovs: This pull request references Jira Issue OCPBUGS-60628, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This prevents sidecar controllers from reverting metadata updates during cluster upgrade.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Aug 19, 2025

/cherrypick release-4.19

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 19, 2025

@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 19, 2025

@vrutkovs: This pull request references Jira Issue OCPBUGS-60628, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

This prevents sidecar controllers from reverting metadata updates during cluster upgrade.

Merging this and its backport to 4.19 will unblock #1870, which shows that currently controllers are rewriting each other metadata changes on upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dinhxuanvu
dinhxuanvu reviewed Aug 19, 2025
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dinhxuanvu,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 19, 2025

/retest-required

Remaining retests: 0 against base HEAD 0c2dfc0 and 2 for PR HEAD c6a4211 in total

@wangke19
Copy link
Contributor

wangke19 commented Aug 19, 2025

/test e2e-aws-ovn-serial-2of2

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 19, 2025

/retest-required

Remaining retests: 0 against base HEAD 0c2dfc0 and 2 for PR HEAD c6a4211 in total

@dinhxuanvu
Copy link
Member

dinhxuanvu commented Aug 19, 2025

/retest-required

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 20, 2025

/retest-required

Remaining retests: 0 against base HEAD 0c2dfc0 and 2 for PR HEAD c6a4211 in total

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 20, 2025

/retest-required

Remaining retests: 0 against base HEAD 0c2dfc0 and 2 for PR HEAD c6a4211 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2025 •
edited
Loading

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn c6a4211 link false /test e2e-azure-ovn
ci/prow/e2e-gcp-operator-single-node c6a4211 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node c6a4211 link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Aug 20, 2025

/test e2e-aws-ovn

@openshift-merge-bot openshift-merge-bot bot merged commit 134fe2d into openshift:main Aug 20, 2025
17 of 20 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 20, 2025

@vrutkovs: Jira Issue OCPBUGS-60628: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-60628 has been moved to the MODIFIED state.

In response to this:

This prevents sidecar controllers from reverting metadata updates during cluster upgrade.

Merging this and its backport to 4.19 will unblock #1870, which shows that currently controllers are rewriting each other metadata changes on upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 20, 2025

@vrutkovs: new pull request created: #1901

In response to this:

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangke19 wangke19 Awaiting requested review from wangke19

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

1 more reviewer

@dinhxuanvu dinhxuanvu dinhxuanvu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dinhxuanvu dinhxuanvu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vrutkovs @openshift-ci-robot @openshift-cherrypick-robot @wangke19 @dinhxuanvu